Page MenuHomePhabricator
Create Task
Maniphest T141787

Add a 'contributions' tab to mobile web stable channel
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Implement a week after it's in the beta channel. The code in beta got merged on 8/9, so a patch that fixes this should not be merged before 8/16.

Details

SubjectRepoBranchLines +/-
Promote contributions button to stable menumediawiki/extensions/MobileFrontendmaster+52 -63
Customize query in gerrit

Related Objects
Search...

Event Timeline

dr0ptp4kt created this task.Aug 1 2016, 4:49 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 1 2016, 4:49 PM
dr0ptp4kt renamed this task from Add a 'contributions' tab to mobile web beta stable channel to Add a 'contributions' tab to mobile web stable channel.Aug 1 2016, 4:50 PM
dr0ptp4kt added a subtask: T117970: Add a 'contributions' tab to mobile web beta channel.
dr0ptp4kt added projects: MobileFrontend, Web-Team-Backlog, Reading-Web-Sprint-79-Uh-oh.
dr0ptp4kt triaged this task as High priority.Aug 1 2016, 4:53 PM
MBinder_WMF moved this task from Incoming to 2016-17 Q2 on the Web-Team-Backlog board.Aug 1 2016, 4:55 PM
dr0ptp4kt moved this task from 2016-17 Q2 to Triaged but Future on the Web-Team-Backlog board.Aug 4 2016, 5:05 PM
MBinder_WMF moved this task from Triaged but Future to 2016-17 Q2 on the Web-Team-Backlog board.Aug 4 2016, 6:02 PM
dr0ptp4kt moved this task from 2016-17 Q2 to Product Owner Backlog on the Web-Team-Backlog board.Aug 4 2016, 6:15 PM
MBinder_WMF moved this task from Product Owner Backlog to 2016-17 Q2 on the Web-Team-Backlog board.Aug 8 2016, 4:14 PM
MBinder_WMF set the point value for this task to 1.Aug 10 2016, 4:26 PM
• bmansurov updated the task description. (Show Details)Aug 10 2016, 4:26 PM
• bmansurov removed the point value for this task.
• jhobs set the point value for this task to 1.Aug 10 2016, 4:29 PM
• jhobs added subscribers: phuedx, • jhobs.

@phuedx Can you flesh out the description a bit to reflect the necessary changes since you were the primary dev on the original feature? Feel free to update the points too if you think it's more complicated than a 1.

• Nirzar closed subtask T117970: Add a 'contributions' tab to mobile web beta channel as Resolved.Aug 10 2016, 5:29 PM
phuedx updated the task description. (Show Details)Aug 11 2016, 8:50 AM
dr0ptp4kt moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-79-Uh-oh board.Aug 15 2016, 4:35 PM
Jdlrobson claimed this task.Aug 15 2016, 7:46 PM
Jdlrobson moved this task from To Do to Blocked Externally on the Reading-Web-Sprint-79-Uh-oh board.
Jdlrobson moved this task from Blocked Externally to Doing on the Reading-Web-Sprint-79-Uh-oh board.
gerritbot subscribed.Aug 15 2016, 7:55 PM

Change 304883 had a related patch set uploaded (by Jdlrobson):
Promote contributions button to stable menu

https://gerrit.wikimedia.org/r/304883

gerritbot added a project: Patch-For-Review.Aug 15 2016, 7:55 PM
Jdlrobson moved this task from Doing to Code Review on the Reading-Web-Sprint-79-Uh-oh board.Aug 15 2016, 8:01 PM
• bmansurov moved this task from Code Review to -1 (Needs More Work) on the Reading-Web-Sprint-79-Uh-oh board.Aug 15 2016, 11:14 PM
Jdlrobson moved this task from -1 (Needs More Work) to Doing on the Reading-Web-Sprint-79-Uh-oh board.Aug 16 2016, 6:28 PM
MBinder_WMF moved this task from 2016-17 Q2 to 2016-17 Q1 on the Web-Team-Backlog board.Aug 16 2016, 6:28 PM
Jdlrobson moved this task from Doing to Code Review on the Reading-Web-Sprint-79-Uh-oh board.Aug 16 2016, 6:35 PM
phuedx updated the task description. (Show Details)Aug 17 2016, 4:48 PM
phuedx updated the task description. (Show Details)
phuedx updated the task description. (Show Details)Aug 17 2016, 4:50 PM

@Jdlrobson: 365dc95 can be merged now, right?

gerritbot added a comment.Aug 17 2016, 4:55 PM

Change 304883 merged by jenkins-bot:
Promote contributions button to stable menu

https://gerrit.wikimedia.org/r/304883

Jdlrobson added a comment.EditedAug 17 2016, 5:08 PM

@phuedx correct.

phuedx updated the task description. (Show Details)Aug 17 2016, 7:14 PM
phuedx moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-79-Uh-oh board.
phuedx reassigned this task from Jdlrobson to dr0ptp4kt.Aug 18 2016, 11:53 AM
phuedx added a subscriber: Jdlrobson.
ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-08-23_(1.28.0-wmf.16)).Aug 18 2016, 4:01 PM
phuedx added a subscriber: • Nirzar.Aug 19 2016, 4:43 PM

@Nirzar: @Jdlrobson's change has been deployed to the Beta Cluster.

phuedx reassigned this task from dr0ptp4kt to • Nirzar.Aug 19 2016, 4:43 PM
• Nirzar added a comment.Aug 19 2016, 4:44 PM

@phuedx so you are sam! :P

i checked on beta yday. looks good.

Jdlrobson closed this task as Resolved.Aug 22 2016, 4:13 PM
Jdlrobson removed a project: Patch-For-Review.

Per @Nirzar

dr0ptp4kt reopened this task as Open.Aug 22 2016, 8:08 PM

Looking good on beta, although re-opening until it takes hold on stable.

dr0ptp4kt claimed this task.Aug 22 2016, 8:54 PM
Jdlrobson created subtask T143796: Update browser tests to reflect absence of watchlist in main menu when anon.Aug 24 2016, 4:07 PM

This has caused a browser test regression which should be fixed before sign off.

phuedx closed subtask T143796: Update browser tests to reflect absence of watchlist in main menu when anon as Resolved.Aug 25 2016, 9:44 PM
phuedx added a comment.Aug 25 2016, 9:46 PM

@dr0ptp4kt: This is now taken hold on MFStable on group 2 Wikipedias.

dr0ptp4kt added a subscriber: • bmansurov.Aug 25 2016, 11:08 PM

I see it on en.m.wikipedia.org stable. Good.

@Jdlrobson, @phuedx, @bmansurov, @jhobs please sign off with regard to T141787#2579317 as appropriate.

phuedx removed dr0ptp4kt as the assignee of this task.Aug 26 2016, 9:50 AM
phuedx closed this task as Resolved.Aug 26 2016, 11:34 AM
phuedx claimed this task.

Per T143796#2584120.

Jdlrobson mentioned this in T237290: Disable mobile beta mode (for now).Nov 4 2019, 6:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits