Page MenuHomePhabricator
Create Task
Maniphest T200263

Pin icon does not show when RevisionSlider is expanded
Closed, ResolvedPublic
Actions

Description

The pin icon and button are not visible when the RevisionSlider is expanded.

Details

SubjectRepoBranchLines +/-
RevisionSlider: Fix missing pin iconmediawiki/extensions/RevisionSliderwmf/1.32.0-wmf.14+4 -0
RevisionSlider: Fix missing pin iconmediawiki/extensions/RevisionSliderwmf/1.32.0-wmf.13+4 -0
RevisionSlider: Fix missing pin iconmediawiki/extensions/RevisionSlidermaster+4 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

WMDE-Fisch triaged this task as Medium priority.Jul 24 2018, 1:14 PM
WMDE-Fisch created this task.
gerritbot subscribed.Jul 24 2018, 1:16 PM

Change 447445 had a related patch set uploaded (by Gopavasanth; owner: Gopavasanth):
[mediawiki/extensions/RevisionSlider@master] RevisionSlider: Fix missing pin icon

https://gerrit.wikimedia.org/r/447445

gerritbot added a project: Patch-For-Review.Jul 24 2018, 1:16 PM
Gopavasanth mentioned this in rERSLc1fada0773cd: RevisionSlider: Fix missing pin icon.Jul 24 2018, 1:17 PM
gerritbot added a comment.Jul 30 2018, 1:02 PM

Change 447445 merged by jenkins-bot:
[mediawiki/extensions/RevisionSlider@master] RevisionSlider: Fix missing pin icon

https://gerrit.wikimedia.org/r/447445

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-31 (1.32.0-wmf.15)).Jul 30 2018, 2:00 PM
gerritbot added a comment.Jul 30 2018, 2:24 PM

Change 449197 had a related patch set uploaded (by WMDE-Fisch; owner: Gopavasanth):
[mediawiki/extensions/RevisionSlider@wmf/1.32.0-wmf.13] RevisionSlider: Fix missing pin icon

https://gerrit.wikimedia.org/r/449197

gerritbot added a comment.Jul 30 2018, 2:25 PM

Change 449198 had a related patch set uploaded (by WMDE-Fisch; owner: Gopavasanth):
[mediawiki/extensions/RevisionSlider@wmf/1.32.0-wmf.14] RevisionSlider: Fix missing pin icon

https://gerrit.wikimedia.org/r/449198

WMDE-Fisch mentioned this in rERSL24655535ae14: RevisionSlider: Fix missing pin icon.Jul 30 2018, 2:26 PM
WMDE-Fisch mentioned this in rERSLb849a4a00f94: RevisionSlider: Fix missing pin icon.
gerritbot added a comment.Jul 30 2018, 2:34 PM

Change 449197 abandoned by WMDE-Fisch:
RevisionSlider: Fix missing pin icon

Reason:
wmf.14 was just deployed ...

https://gerrit.wikimedia.org/r/449197

gerritbot added a comment.Jul 30 2018, 11:21 PM

Change 449198 merged by jenkins-bot:
[mediawiki/extensions/RevisionSlider@wmf/1.32.0-wmf.14] RevisionSlider: Fix missing pin icon

https://gerrit.wikimedia.org/r/449198

Stashbot subscribed.Jul 30 2018, 11:27 PM

Mentioned in SAL (#wikimedia-operations) [2018-07-30T23:27:04Z] <thcipriani@deploy1001> Synchronized php-1.32.0-wmf.14/extensions/RevisionSlider/modules: SWAT: [[gerrit:449198|RevisionSlider: Fix missing pin icon]] T200263 (duration: 00m 49s)

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)); removed MW-1.32-notes (WMF-deploy-2018-07-31 (1.32.0-wmf.15)).Jul 31 2018, 12:01 AM
TheDJ closed this task as Resolved.Jul 31 2018, 11:06 PM
TheDJ removed a project: Patch-For-Review.
thiemowmde removed projects: WMDE volunteer workboard, TCB-Team (now WMDE-TechWish).Jan 7 2022, 2:28 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits