Page MenuHomePhabricator
Create Task
Maniphest T250488

ReCaptchaNoCaptcha not working in VisualEditor
Closed, ResolvedPublic
Actions

Description

When both, the VisualEditor and ConfirmEdit extension, are installed and the ReCaptchaNoCaptcha module is used, then editors who require a Captcha check can not save their edit. The API module for ReCaptchaNoCaptcha is currently not handled by the VisualEditor integration in ConfirmEdit. Therefore, an edit that is aborted by the captcha module is recognized as a general, not handled error in VisualEditor.

It would be great if ReCaptcha would be supported in VisualEditor as well, so that the edit of users who need to solve a captcha is still being able to be saved.

Details

SubjectRepoBranchLines +/-
[reCaptcha] Fix support for VisualEditormediawiki/extensions/ConfirmEditmaster+7 -3
Support ReCaptchaNoCaptcha in VisualEditormediawiki/extensions/ConfirmEditmaster+90 -47
Customize query in gerrit

Event Timeline

Florian created this task.Apr 17 2020, 1:45 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 17 2020, 1:45 PM
gerritbot added a comment.Apr 17 2020, 1:47 PM

Change 589594 had a related patch set uploaded (by Florianschmidtwelzow; owner: Florianschmidtwelzow):
[mediawiki/extensions/ConfirmEdit@master] Support ReCaptchaNoCaptcha in VisualEditor

https://gerrit.wikimedia.org/r/589594

gerritbot added a project: Patch-For-Review.Apr 17 2020, 1:47 PM
gerritbot added a comment.Apr 17 2020, 3:15 PM

Change 589594 abandoned by Florianschmidtwelzow:
Support ReCaptchaNoCaptcha in VisualEditor

Reason:
Bullshit... There's already support for the ReCaptcha module. It's just broken and lives in the ReCaptcha module itself. I'll submit a patch to fix it.

https://gerrit.wikimedia.org/r/589594

gerritbot added a comment.Apr 17 2020, 3:20 PM

Change 589623 had a related patch set uploaded (by Florianschmidtwelzow; owner: Florianschmidtwelzow):
[mediawiki/extensions/ConfirmEdit@master] [reCaptcha] FIx support for VisualEditor

https://gerrit.wikimedia.org/r/589623

• matmarex added a project: Editing-team (Q3 2019-2020 Kanban Board).Apr 17 2020, 6:58 PM
• matmarex moved this task from To Triage to Triaged on the VisualEditor board.
gerritbot added a comment.Apr 17 2020, 7:01 PM

Change 589623 merged by jenkins-bot:
[mediawiki/extensions/ConfirmEdit@master] [reCaptcha] Fix support for VisualEditor

https://gerrit.wikimedia.org/r/589623

• matmarex moved this task from Needs Discussion / Investigation to Ready for Sign Off on the Editing-team (Q3 2019-2020 Kanban Board) board.Apr 17 2020, 7:08 PM
• matmarex edited projects, added Skipped QA; removed Patch-For-Review.
• matmarex subscribed.

(Note that we don't use ReCaptcha on Wikimedia wikis, so we don't have a convenient way for QA to test this.)

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.30; 2020-04-28).Apr 17 2020, 8:01 PM
Florian added a comment.Apr 18 2020, 9:21 AM

@matmarex I'm not that deep into how VE works, but is there a possibility to have a test from somewhere on this side? Something like a JavaScript testing module, which checks, that the plugin is registered? That would not check the functionality itself, sure, but at least we know, if the plugin is there and _would_ work?

ppelberg closed this task as Resolved.May 6 2020, 1:12 AM
ppelberg subscribed.

@Florian I'm going to close this task considering the functionality it is asking for seems, to me, to be implemented.

If this is not the case, please re-open the task... the question you posed in T250488#6067813 still being open led me to want to double check.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptMay 6 2020, 1:12 AM
Florian added a comment.May 13 2020, 3:39 PM

No, I think it's ok to close this task :-) If we find a good way to test this feature, we can still write a patch or a separate task for it :)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits