Page MenuHomePhabricator
Create Task
Maniphest T274539

Implement new VisualEditor template dialog enhanced sidebar feature flag
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

[] Decide where in the code we should fork behavior between the existing template dialog vs. our new design.

  • Add a configuration variable, defaulting to disabled.
  • Fork behavior superficially, can result in an error dialog or empty dialog.

Notes from story time:

  • We are going to group features behind multiple feature flags. The flag in this ticket is for the bulk of changes to the template dialog. The name should say this (e.g. something with "…Sidebar" or "…TemplateDialog").

Related Objects
Search...

Event Timeline

awight created this task.Feb 11 2021, 2:56 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 11 2021, 2:56 PM
awight added a project: VisualEditor-MediaWiki-Templates.Feb 11 2021, 3:20 PM
Maintenance_bot added a project: VisualEditor.Feb 11 2021, 3:46 PM
• matmarex moved this task from To Triage to Triaged on the VisualEditor board.Feb 11 2021, 4:09 PM
thiemowmde updated the task description. (Show Details)Feb 25 2021, 12:45 PM
thiemowmde set the point value for this task to 3.
thiemowmde mentioned this in T274541: Adapt VisualEditor template dialog code to reduce duplication after fork.Feb 25 2021, 12:52 PM
Lena_WMDE moved this task from Backlog to Ready for pickup on the WMDE-Templates-FocusArea board.Mar 2 2021, 1:51 PM
awight added a parent task: T274541: Adapt VisualEditor template dialog code to reduce duplication after fork.Mar 11 2021, 2:39 PM
awight removed a parent task: T274541: Adapt VisualEditor template dialog code to reduce duplication after fork.
awight added a parent task: T274542: Fork / subclass / include variations in BookletLayout for new VisualEditor template dialog.
awight removed a parent task: T272368: Add checkboxes to param list sidebar in VE TemplateDialog.Mar 11 2021, 2:53 PM
awight edited projects, added WMDE-TechWish-Sprint-2021-05-12; removed WMDE-TechWish.May 12 2021, 12:25 PM
awight moved this task from Ready for pickup to In sprint on the WMDE-Templates-FocusArea board.
awight renamed this task from Implement new VisualEditor template dialog feature flag to Implement new VisualEditor template dialog enhanced sidebar feature flag.May 25 2021, 8:47 AM
awight closed this task as Resolved.May 26 2021, 8:20 AM
awight claimed this task.
awight updated the task description. (Show Details)
awight changed the point value for this task from 3 to 1.
awight moved this task from Sprint Backlog to Done on the WMDE-TechWish-Sprint-2021-05-12 board.

Incidentally did this in the course of other work. Moving the "think hard about where to fork" criterion to another task.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits