Page MenuHomePhabricator

Watchlist expiration time is not set correctly if an edit conflict happens
Closed, ResolvedPublicBUG REPORT

Description

Steps to Reproduce:

  1. Log into the wiki using two different accounts (you need to use two browsers or the private mode so that you can switch between both accounts without logging out.
  2. Start editing the page with account 1, don't save.
  3. Edit the page using account 2
  4. Go back to account 1 and set a watchlist expiry time (you might need to check "watch this page", first)
  5. Save and look at the expiry time set in the drop down menu below the summary line

Actual Results:
Expiry time is the same as before the edit

Expected Results:
The expiry time dropdown is preset to the time selected in step 4

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Honischboy renamed this task from Watchlist expiration time is not set correctly when an edit conlict happens to Watchlist expiration time is not set correctly if an edit conlict happens.Feb 12 2021, 4:12 PM
Honischboy renamed this task from Watchlist expiration time is not set correctly if an edit conlict happens to Watchlist expiration time is not set correctly if an edit conflict happens.Feb 15 2021, 6:44 AM
MusikAnimal subscribed.

This is probably an issue with the process cache. At any rate it's not unique to Two-Column-Edit-Conflict-Merge.

In case of the edit conflict the value wpWatchlistExpiry is not used from the request to build the drop down list.

Needs testing for captcha, which also interrupt the edit and may lose the value as well.

Change 957230 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/core@master] Remember selected watchlist expiry time during edit conflict

https://gerrit.wikimedia.org/r/957230

thiemowmde added subscribers: matmarex, Legoktm.

Note this issue is almost a duplicate of T291287: Watchlist expiry is not retained when clicking "show changes", but works on "show preview".

I came up with a possible patch, see https://gerrit.wikimedia.org/r/957230. I tested it with and without Two-Column-Edit-Conflict-Merge and can confirm the extension is unrelated.

The relevant code touched in the patch was originally added via T248494 and last touched in https://gerrit.wikimedia.org/r/910465, which is indirectly linked to T201613. That's in the realm of the Editing-team.

That's in the realm of the Editing-team.

I'm not sure if they feel that way, it was mostly just me working in this area… Anyway, I'm happy to review the change.

Change 957230 merged by jenkins-bot:

[mediawiki/core@master] Remember selected watchlist expiry time during edit conflict

https://gerrit.wikimedia.org/r/957230

matmarex assigned this task to thiemowmde.