Page MenuHomePhabricator
Create Task
Maniphest T312223

Use FallbackLabelDescriptionLookupFactory in code
Closed, ResolvedPublic
Actions

Description

Once the new FallbackLabelDescriptionLookupFactory has been created (T312222), it should be used by most places that want a FallbackLabelDescriptionLookup; this especially includes most (possibly all) users of LanguageFallbackLabelDescriptionLookupFactory. See also the list in T305032#8052212.

Details

SubjectRepoBranchLines +/-
Use FallbackLabelDescriptionLookupFactory in AboutTopicRenderermediawiki/extensions/ArticlePlaceholdermaster+14 -14
Use FallbackLabelDescriptionLookupFactory in DataAccessSnakFormatterFactorymediawiki/extensions/Wikibasemaster+24 -36
Use FallbackLabelDescriptionLookupFactory in SpecialPagesWithBadgesmediawiki/extensions/Wikibasemaster+23 -39
Use FallbackLabelDescriptionLookupFactory in newSnakSerializationRenderermediawiki/extensions/Wikibasemaster+2 -13
Use FallbackLabelDescriptionLookupFactory in SidebarLinkBadgeDisplaymediawiki/extensions/Wikibasemaster+4 -20
Use FallbackLabelDescriptionLookupFactory in SpecialSetSiteLinkmediawiki/extensions/Wikibasemaster+7 -9
Use FallbackLabelDescriptionLookupFactory in SpecialListPropertiesmediawiki/extensions/Wikibasemaster+54 -66
Use FallbackLabelDescriptionLookupFactory in EntityIdLabelFormatterFactorymediawiki/extensions/Wikibasemaster+1 -1
Use FallbackLabelDescriptionLookupFactory in Hooksmediawiki/extensions/WikibaseCirrusSearchmaster+7 -11
Use FallbackLabelDescriptionLookupFactory in PropertyHandlermediawiki/extensions/Wikibasemaster+8 -8
Use FallbackLabelDescriptionLookupFactory in ItemHandlermediawiki/extensions/Wikibasemaster+9 -9
Use FallbackLabelDescriptionLookupFactory in MathWikibaseConfigmediawiki/extensions/Mathmaster+7 -7
Use FallbackLabelDescriptionLookupFactory in entity search callbacksmediawiki/extensions/Wikibasemaster+5 -11
Use FallbackLabelDescriptionLookupFactory in SpecialNewLexemeAlphamediawiki/extensions/WikibaseLexememaster+12 -12
Use FallbackLabelDescriptionLookupFactory in SpecialNewLexememediawiki/extensions/WikibaseLexememaster+2 -1
Use FallbackLabelDescriptionLookupFactory in client hook handlersmediawiki/extensions/Wikibasemaster+20 -26
Use FallbackLabelDescriptionLookupFactory in property entity typesmediawiki/extensions/Wikibasemaster+2 -4
Use FallbackLabelDescriptionLookupFactory in item entity typesmediawiki/extensions/Wikibasemaster+4 -2
Use FallbackLabelDescriptionLookupFactory in LexemeHandlermediawiki/extensions/WikibaseLexememaster+9 -12
Use FallbackLabelDescriptionLookupFactory for meta tags creatormediawiki/extensions/WikibaseLexememaster+7 -10
Use FallbackLabelDescriptionLookupFactory for Lexeme formattermediawiki/extensions/WikibaseLexememaster+2 -2
Use FallbackLabelDescriptionLookupFactory for Form formattermediawiki/extensions/WikibaseLexememaster+2 -3
Use FallbackLabelDescriptionLookupFactory for Form ID formattermediawiki/extensions/WikibaseLexememaster+2 -4
Use FallbackLabelDescriptionLookupFactory for Lexeme ID formattermediawiki/extensions/WikibaseLexememaster+2 -7
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

• Lucas_Werkmeister_WMDE created this task.Jul 6 2022, 1:31 PM
• Lucas_Werkmeister_WMDE mentioned this in T312224: Remove LanguageFallbackLabelDescriptionLookupFactory.
• Lucas_Werkmeister_WMDE mentioned this in T305032: Lexeme pages do not show labels of redirected Items (unlike Item pages).
• Lucas_Werkmeister_WMDE claimed this task.Jul 7 2022, 1:31 PM
• Lucas_Werkmeister_WMDE moved this task from To Do to Doing on the Special:NewLexeme revival (Special:NewLexeme revival - sprint 11) board.
gerritbot added a comment.Jul 7 2022, 4:10 PM

Change 812024 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseLexeme@master] Use FallbackLabelDescriptionLookupFactory for Lexeme ID formatter

https://gerrit.wikimedia.org/r/812024

gerritbot added a project: Patch-For-Review.Jul 7 2022, 4:10 PM

Change 812025 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseLexeme@master] Use FallbackLabelDescriptionLookupFactory for Form ID formatter

https://gerrit.wikimedia.org/r/812025

gerritbot added a comment.Jul 7 2022, 4:10 PM

Change 812026 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseLexeme@master] Use FallbackLabelDescriptionLookupFactory for Lexeme formatter

https://gerrit.wikimedia.org/r/812026

gerritbot added a comment.Jul 7 2022, 4:10 PM

Change 812027 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseLexeme@master] Use FallbackLabelDescriptionLookupFactory for Form formatter

https://gerrit.wikimedia.org/r/812027

gerritbot added a comment.Jul 7 2022, 4:10 PM

Change 812028 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseLexeme@master] Use FallbackLabelDescriptionLookupFactory for meta tags creator

https://gerrit.wikimedia.org/r/812028

gerritbot added a comment.Jul 7 2022, 4:10 PM

Change 812029 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseLexeme@master] Use FallbackLabelDescriptionLookupFactory in LexemeHandler

https://gerrit.wikimedia.org/r/812029

gerritbot added a comment.Jul 8 2022, 8:57 AM

Change 812244 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseLexeme@master] Use FallbackLabelDescriptionLookupFactory in SpecialNewLexemeAlpha

https://gerrit.wikimedia.org/r/812244

gerritbot added a comment.Jul 8 2022, 1:49 PM

Change 812024 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Use FallbackLabelDescriptionLookupFactory for Lexeme ID formatter

https://gerrit.wikimedia.org/r/812024

gerritbot added a comment.Jul 8 2022, 1:50 PM

Change 812025 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Use FallbackLabelDescriptionLookupFactory for Form ID formatter

https://gerrit.wikimedia.org/r/812025

gerritbot added a comment.Jul 8 2022, 1:58 PM

Change 812026 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Use FallbackLabelDescriptionLookupFactory for Lexeme formatter

https://gerrit.wikimedia.org/r/812026

gerritbot added a comment.Jul 8 2022, 2:01 PM

Change 812027 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Use FallbackLabelDescriptionLookupFactory for Form formatter

https://gerrit.wikimedia.org/r/812027

gerritbot added a comment.Jul 8 2022, 3:46 PM

Change 812028 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Use FallbackLabelDescriptionLookupFactory for meta tags creator

https://gerrit.wikimedia.org/r/812028

gerritbot added a comment.Jul 8 2022, 4:03 PM

Change 812029 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Use FallbackLabelDescriptionLookupFactory in LexemeHandler

https://gerrit.wikimedia.org/r/812029

• Lucas_Werkmeister_WMDE mentioned this in T312658: Show Labels from redirected Languages/LexicalCategories?.Jul 11 2022, 10:21 AM
gerritbot added a comment.Jul 11 2022, 10:38 AM

Change 812839 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Use FallbackLabelDescriptionLookupFactory in entity types

https://gerrit.wikimedia.org/r/812839

• Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Special:NewLexeme revival (Special:NewLexeme revival - sprint 11) board.Jul 11 2022, 10:38 AM
gerritbot added a comment.Jul 11 2022, 2:16 PM

Change 812871 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseLexeme@master] Use FallbackLabelDescriptionLookupFactory in SpecialNewLexeme

https://gerrit.wikimedia.org/r/812871

• Lucas_Werkmeister_WMDE mentioned this in T312780: Provide EntityRevisionLookup for federated properties.Jul 11 2022, 2:39 PM
gerritbot added a comment.Jul 11 2022, 3:49 PM

Change 812896 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Use FallbackLabelDescriptionLookupFactory in client hook handlers

https://gerrit.wikimedia.org/r/812896

• Lucas_Werkmeister_WMDE closed subtask T312780: Provide EntityRevisionLookup for federated properties as Declined.Jul 11 2022, 4:35 PM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.21; 2022-07-18).Jul 12 2022, 5:02 AM
karapayneWMDE added a project: Wikidata Dev Team (Sprint-∞).Jul 12 2022, 8:38 AM
karapayneWMDE moved this task from Parents/Waiting to Peer Review on the Wikidata Dev Team (Sprint-∞) board.
gerritbot added a comment.Jul 12 2022, 10:20 AM

Change 813212 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Use FallbackLabelDescriptionLookupFactory in property entity types

https://gerrit.wikimedia.org/r/813212

gerritbot added a comment.Jul 13 2022, 10:47 AM

Change 812839 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use FallbackLabelDescriptionLookupFactory in item entity types

https://gerrit.wikimedia.org/r/812839

gerritbot added a comment.Jul 13 2022, 11:06 AM

Change 813212 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use FallbackLabelDescriptionLookupFactory in property entity types

https://gerrit.wikimedia.org/r/813212

gerritbot added a comment.Jul 13 2022, 11:08 AM

Change 812896 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use FallbackLabelDescriptionLookupFactory in client hook handlers

https://gerrit.wikimedia.org/r/812896

gerritbot added a comment.Jul 13 2022, 11:08 AM

Change 812871 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Use FallbackLabelDescriptionLookupFactory in SpecialNewLexeme

https://gerrit.wikimedia.org/r/812871

• Lucas_Werkmeister_WMDE closed subtask T312791: Implement FallbackLabelDescriptionLookup that supports federated properties as Resolved.Jul 13 2022, 11:08 AM
gerritbot added a comment.Jul 13 2022, 11:25 AM

Change 812244 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Use FallbackLabelDescriptionLookupFactory in SpecialNewLexemeAlpha

https://gerrit.wikimedia.org/r/812244

• Lucas_Werkmeister_WMDE moved this task from Peer Review to Doing on the Wikidata Dev Team (Sprint-∞) board.Jul 13 2022, 11:27 AM
gerritbot added a comment.Jul 13 2022, 2:57 PM

Change 813635 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Use FallbackLabelDescriptionLookupFactory for entity search callbacks

https://gerrit.wikimedia.org/r/813635

• Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikidata Dev Team (Sprint-∞) board.Jul 13 2022, 2:57 PM
gerritbot added a comment.Jul 13 2022, 3:15 PM

Change 813637 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Use FallbackLabelDescriptionLookupFactory in ItemHandler

https://gerrit.wikimedia.org/r/813637

gerritbot added a comment.Jul 13 2022, 3:20 PM

Change 813639 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Use FallbackLabelDescriptionLookupFactory in PropertyHandler

https://gerrit.wikimedia.org/r/813639

gerritbot added a comment.Jul 13 2022, 3:36 PM

Change 813647 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Use FallbackLabelDescriptionLookupFactory in EntityIdLabelFormatterFactory

https://gerrit.wikimedia.org/r/813647

gerritbot added a comment.Jul 13 2022, 3:44 PM

Change 813635 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use FallbackLabelDescriptionLookupFactory in entity search callbacks

https://gerrit.wikimedia.org/r/813635

gerritbot added a comment.Jul 13 2022, 4:28 PM

Change 813656 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Use FallbackLabelDescriptionLookupFactory in SpecialSetSiteLink

https://gerrit.wikimedia.org/r/813656

gerritbot added a comment.Jul 13 2022, 4:36 PM

Change 813659 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Math@master] Use FallbackLabelDescriptionLookupFactory in MathWikibaseConfig

https://gerrit.wikimedia.org/r/813659

gerritbot added a comment.Jul 14 2022, 2:55 PM

Change 813659 merged by jenkins-bot:

[mediawiki/extensions/Math@master] Use FallbackLabelDescriptionLookupFactory in MathWikibaseConfig

https://gerrit.wikimedia.org/r/813659

gerritbot added a comment.Jul 15 2022, 10:06 AM

Change 814118 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Use FallbackLabelDescriptionLookupFactory in SpecialListProperties

https://gerrit.wikimedia.org/r/814118

gerritbot added a comment.Jul 15 2022, 10:14 AM

Change 814119 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseCirrusSearch@master] Use FallbackLabelDescriptionLookupFactory in Hooks

https://gerrit.wikimedia.org/r/814119

gerritbot added a comment.Jul 15 2022, 1:44 PM

Change 814171 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Use FallbackLabelDescriptionLookupFactory in SidebarLinkBadgeDisplay

https://gerrit.wikimedia.org/r/814171

gerritbot added a comment.Jul 15 2022, 1:57 PM

Change 814173 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Use FallbackLabelDescriptionLookupFactory in SpecialPagesWithBadges

https://gerrit.wikimedia.org/r/814173

gerritbot added a comment.Jul 15 2022, 2:32 PM

Change 814179 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Use FallbackLabelDescriptionLookupFactory in newSnakSerializationRenderer

https://gerrit.wikimedia.org/r/814179

Physikerwelt subscribed.Jul 15 2022, 3:24 PM

Stating the obvious:

For extensions, this creates a dependency on 1.39-wmf.21 . Otherwise you will see

Call to undefined method Wikibase\Client\WikibaseClient::getFallbackLabelDescriptionLookupFactory()

;-)

gerritbot added a comment.Jul 18 2022, 9:23 AM

Change 813637 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use FallbackLabelDescriptionLookupFactory in ItemHandler

https://gerrit.wikimedia.org/r/813637

gerritbot added a comment.Jul 18 2022, 9:52 AM

Change 813639 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use FallbackLabelDescriptionLookupFactory in PropertyHandler

https://gerrit.wikimedia.org/r/813639

gerritbot added a comment.Jul 18 2022, 10:47 AM

Change 814119 merged by jenkins-bot:

[mediawiki/extensions/WikibaseCirrusSearch@master] Use FallbackLabelDescriptionLookupFactory in Hooks

https://gerrit.wikimedia.org/r/814119

gerritbot added a comment.Jul 21 2022, 10:57 PM

Change 813647 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use FallbackLabelDescriptionLookupFactory in EntityIdLabelFormatterFactory

https://gerrit.wikimedia.org/r/813647

gerritbot added a comment.Jul 21 2022, 10:59 PM

Change 813656 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use FallbackLabelDescriptionLookupFactory in SpecialSetSiteLink

https://gerrit.wikimedia.org/r/813656

gerritbot added a comment.Jul 21 2022, 10:59 PM

Change 814118 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use FallbackLabelDescriptionLookupFactory in SpecialListProperties

https://gerrit.wikimedia.org/r/814118

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.22; 2022-07-25); removed MW-1.39-notes (1.39.0-wmf.21; 2022-07-18).Jul 21 2022, 11:00 PM
gerritbot added a comment.Jul 25 2022, 3:26 PM

Change 814171 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use FallbackLabelDescriptionLookupFactory in SidebarLinkBadgeDisplay

https://gerrit.wikimedia.org/r/814171

gerritbot added a comment.Jul 25 2022, 3:26 PM

Change 814173 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use FallbackLabelDescriptionLookupFactory in SpecialPagesWithBadges

https://gerrit.wikimedia.org/r/814173

gerritbot added a comment.Jul 25 2022, 3:27 PM

Change 814179 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use FallbackLabelDescriptionLookupFactory in newSnakSerializationRenderer

https://gerrit.wikimedia.org/r/814179

• Lucas_Werkmeister_WMDE moved this task from Peer Review to Doing on the Wikidata Dev Team (Sprint-∞) board.Jul 25 2022, 3:31 PM
gerritbot added a comment.Jul 25 2022, 4:10 PM

Change 816816 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Use FallbackLabelDescriptionLookupFactory in DataAccessSnakFormatterFactory

https://gerrit.wikimedia.org/r/816816

• Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikidata Dev Team (Sprint-∞) board.Jul 25 2022, 4:18 PM
gerritbot added a comment.Jul 25 2022, 5:18 PM

Change 816816 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use FallbackLabelDescriptionLookupFactory in DataAccessSnakFormatterFactory

https://gerrit.wikimedia.org/r/816816

• Lucas_Werkmeister_WMDE moved this task from Peer Review to Doing on the Special:NewLexeme revival (Special:NewLexeme revival - sprint 11) board.Jul 26 2022, 8:24 AM

Wikibase is pretty much done, but a few other extensions are still using the old factory (see codesearch).

• Lucas_Werkmeister_WMDE moved this task from Peer Review to Doing on the Wikidata Dev Team (Sprint-∞) board.Jul 26 2022, 9:03 AM
gerritbot added a comment.Jul 26 2022, 10:57 AM

Change 817219 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/ArticlePlaceholder@master] Use FallbackLabelDescriptionLookupFactory in AboutTopicRenderer

https://gerrit.wikimedia.org/r/817219

gerritbot added a comment.Jul 26 2022, 1:04 PM

Change 817219 merged by jenkins-bot:

[mediawiki/extensions/ArticlePlaceholder@master] Use FallbackLabelDescriptionLookupFactory in AboutTopicRenderer

https://gerrit.wikimedia.org/r/817219

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.23; 2022-08-01); removed MW-1.39-notes (1.39.0-wmf.22; 2022-07-25).Jul 26 2022, 2:00 PM
• Lucas_Werkmeister_WMDE closed this task as Resolved.Jul 28 2022, 10:45 AM
• Lucas_Werkmeister_WMDE moved this task from Doing to Our work done on the Wikidata Dev Team (Sprint-∞) board.
• Lucas_Werkmeister_WMDE moved this task from Incoming to Our work done on the Wikidata-Campsite (Team A Hearth 🏰🔥) board.
• Lucas_Werkmeister_WMDE moved this task from Doing to Done on the Special:NewLexeme revival (Special:NewLexeme revival - sprint 11) board.
karapayneWMDE moved this task from Our work done to 2022 Completed Tasks on the Wikidata Dev Team (Sprint-∞) board.Aug 9 2022, 9:53 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits