Add the "user-rights" icon to OOUI and Codex
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	Daimona
	Jun 7 2023, 4:38 PM

Description

Background & Goal

Description: The user-rights icon used by Echo can be found in the Figma assets, but not in OOUI and Codex.
History: I'm not aware of previous discussions about this, but the absence of the icon looks a bit weird. Maybe it was always meant to be in OOUI and Codex, but no-one noticed it actually isn't?
Known use case(s): Aside from Echo, the Campaigns team would like to use the icon in the CampaignEvents extension; in particular, see F36852648 / T318165, where the icon is used to introduce a list of event organizers.
Considerations: ∅

User stories

As an event participant, I want to recognise event organizers at a glance, without confusing them with other participants.

Proposal

Redesign the current userRight icon to be the same bust as userAvatar. Also, we need the RTL version.

Captura de pantalla 2023-06-12 a las 10.17.51.png (540×1 px, 40 KB)

Design spec

Figma exploration file

SVG icon

userRights-icon.zip2 KBDownload

Acceptance criteria for Done

Design

The design of the new icon is ready, and it follows our icon system guidelines
The new icon has been reviewed with help from the DST
An RTL icon has been created (if needed)
The icon is recognizable on low DPI resolutions
The icon has been exported as an optimized SVG and added to this task’s description
The new icon has been included and published in our Icon System Figma library

Code

Add icon in Codex
Add icon in OOUI

Documentation

Update T141801: WikimediaUI (Codex/OOUI) icon inventory (tracking)

Details

Subject	Repo	Branch	Lines +/-
Update OOUI to v0.47.3	mediawiki/core	master	+433 -145
Update Codex from v0.13.0 to v0.14.0	mediawiki/core	master	+526 -522
Icons: Add user rights icon to OOUI	oojs/ui	master	+26 -0
Icons: Add user rights icon to Codex	design/codex	main	+13 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		• Catrope	T340121 Release OOUI v0.47.2
		Resolved		lwatson	T338344 Add the "user-rights" icon to OOUI and Codex

Event Timeline

Daimona created this task.Jun 7 2023, 4:38 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 7 2023, 4:38 PM

I'm not aware of previous discussions about this, but the absence of the icon looks a bit weird. Maybe it was always meant to be in OOUI and Codex, but no-one noticed it actually isn't?

No, it was intentionally not put into OOUI as it was agreed that it was a single-use icon and shouldn't bloat the library for other users. Codex inherited that decision. Obviously if needs change it can adjust.

In T338344#8910497, @Jdforrester-WMF wrote:

I'm not aware of previous discussions about this, but the absence of the icon looks a bit weird. Maybe it was always meant to be in OOUI and Codex, but no-one noticed it actually isn't?

No, it was intentionally not put into OOUI as it was agreed that it was a single-use icon and shouldn't bloat the library for other users. Codex inherited that decision. Obviously if needs change it can adjust.

Ohhhh interesting, thank you! We were not aware of that, we just found it strange that the icon was in figma but not in OOUI and Codex. CC'ing @Catrope and @gonyeahialam, too, given our previous conversations.

One additional piece of context that may or may not be relevant to the decision around this icon - the Product & Technology annual plan includes a key result focused on users with extended rights (WE1, KR2):

Complete improvements to four workflows that improve the experience of editors with extended rights (admins, patrollers, functionaries, and moderators of all kinds); extend their creativity; impact at least four different wikis, and meet KRs for each improvement set collaboratively with the volunteers.

ldelench_wmf added projects: Campaign-Tools, Campaign-Registration.Jun 9 2023, 4:52 PM

ldelench_wmf moved this task from Backlog to Following on the Campaign-Tools board.

bmartinezcalvo attached a referenced file: F36852648: image.png. (Show Details)Jun 12 2023, 7:56 AM

Since we are going to add this icon in Codex and OOUI, I would improve a couple of things:

The body bust is different from other user icons. I would use the userAvatar body to create this userRight.


Current icon	New icon

We need the RTL version of the icon since the settings modifier should be mirrored.

I've created this exploration file with the proposal.

Thank you @bmartinezcalvo for the modifications.
I have checked the explorations, and it looks good to me.
What would be the next steps?

In T338344#8929539, @gonyeahialam wrote:

Thank you @bmartinezcalvo for the modifications.
I have checked the explorations, and it looks good to me.
What would be the next steps?

@gonyeahialam so if you all agree with the new userRights icon, and following the acceptance criteria in the task, next steps will be to include both LTR and RTL in Codex and OOUI. So I'm sharing the SVG for both versions here.
{F37111044}

I will replace the icon in the Figma Assets library once we add this in code.

bmartinezcalvo updated the task description. (Show Details)Jun 14 2023, 7:02 AM

Okay, thank you @bmartinezcalvo