Commons:Bots/Requests/OrophinBot 2
OrophinBot (talk · contribs)
Bot's tasks for which permission is being sought: Batch upload of 3000 bible illustrations from http://www.dsmedia.org/resources/illustrations/sweet-publishing See Commons:Batch uploading/Bible Illustrations and Commons:Bible Illustrations. The images will be categorized based on book and chapter
Automatic or manually assisted: Automatic
Edit type (e.g. Continuous, daily, one time run): One time run
Maximum edit rate (eg edits per minute): 2-8 uploads/minute depends on file size
Bot flag requested: (Y/N): N
Programming language(s): VBScript
Smallman12q (talk) 14:39, 14 March 2012 (UTC) filed on behalf of User:Bennylin
Discussion
- Please make test uploads. --EugeneZelenko (talk) 14:42, 14 March 2012 (UTC)
- Will do. Bennylin (yes?) 08:22, 15 March 2012 (UTC)
- You can see the initial uploads at subcategories of Category:Media_contributed_by_the_Sweet_Publishing Smallman12q (talk) 23:58, 18 March 2012 (UTC)
- Done Test upload: Category:Book of Revelation (Bible Illustrations by Sweet Media) (10 files). Bennylin (yes?) 11:41, 19 March 2012 (UTC)
- I think will be good idea to create more unique name for template, since much more sources of illustrations then Sweet Publishing are possible.
- Is Template:Bible Illustrations (Sweet Publishing)-information a good name? Would I need some kind of permission for mass page-moving? Bennylin (yes?) 15:18, 19 March 2012 (UTC)
- Yes, it's more unique template name. --EugeneZelenko (talk) 14:51, 20 March 2012 (UTC)
- Is Template:Bible Illustrations (Sweet Publishing)-information a good name? Would I need some kind of permission for mass page-moving? Bennylin (yes?) 15:18, 19 March 2012 (UTC)
- Will be good idea to wrap KJV parameter value into language template. Same for Source text in template.
- You mean the KJV verse would only display if the user language is 'en'? What about the Source text? Do you mean I should i18 it?
- In both cases English text should be wrapped into {{En}}. --EugeneZelenko (talk) 14:51, 20 March 2012 (UTC)
- The parameter is not used anymore. Bennylin (yes?) 12:54, 28 March 2012 (UTC)
- In both cases English text should be wrapped into {{En}}. --EugeneZelenko (talk) 14:51, 20 March 2012 (UTC)
- You mean the KJV verse would only display if the user language is 'en'? What about the Source text? Do you mean I should i18 it?
- Category:Book of Revelation looks excessive, but this should be fixed in template.
- EugeneZelenko (talk) 14:31, 19 March 2012 (UTC)
- Do you mean its too detailed? Bennylin (yes?) 15:22, 19 March 2012 (UTC)
- It's too general. Images are included in subcategories already. --EugeneZelenko (talk) 14:51, 20 March 2012 (UTC)
- So, scrap the subcategories (per chapter)? Bennylin (yes?) 08:23, 21 March 2012 (UTC)
- It's too general. Images are included in subcategories already. --EugeneZelenko (talk) 14:51, 20 March 2012 (UTC)
- For the four gospels, the image are quite a lot and would need to be categorized by chapter for ease of use (see Commons:Bible_Illustrations#Statistics). But I agree that category like Category:Epistle to Titus Chapter 1 (Bible Illustrations by Sweet Media) would not be needed. But it's inherent in the code, and i don't think there's an easy way to select which book should have subcategories and which book shouldn't. Bennylin (yes?) 08:35, 20 March 2012 (UTC)
- Do you mean its too detailed? Bennylin (yes?) 15:22, 19 March 2012 (UTC)
- I think will be good idea to create more unique name for template, since much more sources of illustrations then Sweet Publishing are possible.
- Done Test upload: Category:Book of Revelation (Bible Illustrations by Sweet Media) (10 files). Bennylin (yes?) 11:41, 19 March 2012 (UTC)
- You can see the initial uploads at subcategories of Category:Media_contributed_by_the_Sweet_Publishing Smallman12q (talk) 23:58, 18 March 2012 (UTC)
- Will do. Bennylin (yes?) 08:22, 15 March 2012 (UTC)
Comment- I'm not sure if the {{Bible Illustrations-information}} template is appropriate. Virtually all uploads use the {{Information}} template (it makes it possible for other bots to parse the file). Also, do you want to add a description for each as they upload (do you plan to add descriptions to all of them)? Quoting the bible is fine, but it's not really descriptive, a description + source passage would be better.Smallman12q (talk) 23:58, 19 March 2012 (UTC)
- How about using that template for substituting purpose? That way it would be simpler for the code. I've tweaked the templates. Please take a look at them. As for the KJV quote, it's just for example. The description should be automatic in multilingual, given the parameter 'book' and 'chapter', and the number of translation can be expanded simultaneously without having to edit each of the 3000 images. Bennylin (yes?) 08:06, 20 March 2012 (UTC)
Please see my second upload test (21 files in 5 epistles categories) using the latest code based on the comments on this page. Bennylin (yes?) 08:51, 20 March 2012 (UTC)
- Looks fine. Could you update the code at User:Smallbot/source/bible upload.vbs. It seems like you removed the "Book of " segments (hope you found the script readable). Still need final approval from EugeneZelenko for upload.Smallman12q (talk) 21:12, 20 March 2012 (UTC)
- I've updated the code. Bennylin (yes?) 08:23, 21 March 2012 (UTC)
- It doesn't seem like the code was updated to what's being used. The code posted prepends articles with "Book of", yours does not. Also, I've realized there's a small logic bug in that if you resume in a folder where the chapter needs to be bumped up one (because it started at 0, instead of 1), it won't bump that chapter up one. I'll correct/cleanup the code after you post the code you're using (which doesn't prepend articles with "Book of").
- I can easily delete the subcategories which have less than x amount of pictures after the upload is done, and remove them from associated images if needed. I'm not sure what we should do with the duplicate images?Smallman12q (talk) 01:51, 22 March 2012 (UTC)
- Compare using diff, and you'll see that the assumption was changed too. Folder should be named according to the category, so it's Book of Revelation instead of Revelation, Epistle of James, instead of James (which would get Book of James with the old code). Bennylin (yes?) 04:32, 22 March 2012 (UTC)
- I've updated the code. Bennylin (yes?) 08:23, 21 March 2012 (UTC)
So, is it good to go? Bennylin (yes?) 06:27, 24 March 2012 (UTC)
- Could you please perform final test run to check all suggestions implemented or not? --EugeneZelenko (talk) 14:28, 26 March 2012 (UTC)
- Sure. Bennylin (yes?) 05:49, 27 March 2012 (UTC)
- Done I've run a third test for 12 files in Category:Book of Jonah (Bible Illustrations by Sweet Media) Bennylin (yes?) 12:54, 28 March 2012 (UTC)
- Looks like problems remain in templates. Based on File:Book of Jonah Chapter 4-3 (Bible Illustrations by Sweet Media).jpg:
- Source filed should be internationalized by wrapping in {{En}}.
- General category (Book of Jonah) should be excluded.
- Please fix templates, I don't see any other problems with uploads themselves.
- EugeneZelenko (talk) 14:49, 28 March 2012 (UTC)
- Done Source filed should be internationalized by wrapping in {{En}}.
- Done General category (Book of Jonah) should be excluded.
- I'll upload the rest starting tomorrow. Thanks for all the comments. Bennylin (yes?) 18:12, 28 March 2012 (UTC)
- Looks like problems remain in templates. Based on File:Book of Jonah Chapter 4-3 (Bible Illustrations by Sweet Media).jpg: