Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for creating raw derived columns during segment reload #13037

Merged
merged 6 commits into from
May 9, 2024

Conversation

yashmayya
Copy link
Collaborator

  • Support for generating derived columns during segment reload was added in Support generating derived column during segment load #6494.
  • However, support for generating raw derived columns during segment reload wasn't added then and was mentioned as a future TODO.
  • This patch adds support for generating raw (i.e., not dictionary encoded) derived columns during segment reload.

@codecov-commenter
Copy link

codecov-commenter commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 54.02299% with 40 lines in your changes missing coverage. Please review.

Project coverage is 62.19%. Comparing base (59551e4) to head (44c572f).
Report is 1001 commits behind head on master.

Files with missing lines Patch % Lines
...loader/defaultcolumn/BaseDefaultColumnHandler.java 53.08% 36 Missing and 2 partials ⚠️
...x/loader/defaultcolumn/V3DefaultColumnHandler.java 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #13037      +/-   ##
============================================
+ Coverage     61.75%   62.19%   +0.44%     
+ Complexity      207      198       -9     
============================================
  Files          2436     2507      +71     
  Lines        133233   137833    +4600     
  Branches      20636    21334     +698     
============================================
+ Hits          82274    85725    +3451     
- Misses        44911    45714     +803     
- Partials       6048     6394     +346     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration <0.01% <0.00%> (-0.01%) ⬇️
integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration2 0.00% <0.00%> (ø)
java-11 62.12% <54.02%> (+0.42%) ⬆️
java-21 62.08% <54.02%> (+0.46%) ⬆️
skip-bytebuffers-false 62.15% <54.02%> (+0.40%) ⬆️
skip-bytebuffers-true 62.07% <54.02%> (+34.34%) ⬆️
temurin 62.19% <54.02%> (+0.44%) ⬆️
unittests 62.19% <54.02%> (+0.44%) ⬆️
unittests1 46.83% <0.00%> (-0.06%) ⬇️
unittests2 27.77% <54.02%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jackie-Jiang Jackie-Jiang added feature release-notes Referenced by PRs that need attention when compiling the next release notes labels Apr 30, 2024
@yashmayya yashmayya marked this pull request as ready for review May 6, 2024 10:33
@yashmayya yashmayya force-pushed the raw-derived-columns branch 2 times, most recently from c09ab62 to 881f243 Compare May 6, 2024 11:08
Copy link
Contributor

@Jackie-Jiang Jackie-Jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great job!

@xiangfu0 xiangfu0 merged commit 760e952 into apache:master May 9, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature release-notes Referenced by PRs that need attention when compiling the next release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants