-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for creating raw derived columns during segment reload #13037
Conversation
yashmayya
commented
Apr 30, 2024
- Support for generating derived columns during segment reload was added in Support generating derived column during segment load #6494.
- However, support for generating raw derived columns during segment reload wasn't added then and was mentioned as a future TODO.
- This patch adds support for generating raw (i.e., not dictionary encoded) derived columns during segment reload.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #13037 +/- ##
============================================
+ Coverage 61.75% 62.19% +0.44%
+ Complexity 207 198 -9
============================================
Files 2436 2507 +71
Lines 133233 137833 +4600
Branches 20636 21334 +698
============================================
+ Hits 82274 85725 +3451
- Misses 44911 45714 +803
- Partials 6048 6394 +346
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
c09ab62
to
881f243
Compare
…eationInfo; convert arrays of primitive wrapper values to primitive arrays for MV raw index
881f243
to
7d92da3
Compare
.../apache/pinot/segment/local/segment/index/loader/defaultcolumn/BaseDefaultColumnHandler.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great job!