Move resolveComparisonTies from addOrReplaceSegment to base class #13396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tibrewalpratik17
force-pushed
the
minor_refactor_upsert
branch
from
6988816
to
a9b4b8c
Compare
tibrewalpratik17
added
upsert
refactor
backward-incompat
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #13396 +/- ##
============================================
+ Coverage 61.75% 62.00% +0.25%
+ Complexity 207 198 -9
============================================
Files 2436 2550 +114
Lines 133233 140263 +7030
Branches 20636 21799 +1163
============================================
+ Hits 82274 86974 +4700
- Misses 44911 46680 +1769
- Partials 6048 6609 +561
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
klsince
reviewed
Jun 14, 2024
.../src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java
Outdated
Show resolved
Hide resolved
tibrewalpratik17
removed
the
backward-incompat
klsince
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving
resolveComparisonTiesfromaddOrReplaceSegmentto base class.There are 2 ways of doing this:
resolveComparisonTiesin base class before callingaddOrReplaceSegment. There are 3 instances ofaddOrReplaceSegmentcalls in base class.resolveComparisonTiesinsideaddOrReplaceSegmentmethod in base class itself and change the abstract method name todoAddOrReplaceSegment. This is in parity with other methods we have in extended class -doAddRecord,doRemoveExpiredPrimaryKeys,doUpdateRecordwhere we prefix the abstract method bydo.We are doing the latter here.