Refactoring removeSegment flow in upsert #13449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.../src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java
Outdated
Show resolved
Hide resolved
tibrewalpratik17
force-pushed
the
refactor_upsert
branch
from
e2c785e
to
6d5b33d
Compare
.../src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #13449 +/- ##
============================================
+ Coverage 61.75% 62.04% +0.29%
+ Complexity 207 198 -9
============================================
Files 2436 2559 +123
Lines 133233 141356 +8123
Branches 20636 21928 +1292
============================================
+ Hits 82274 87702 +5428
- Misses 44911 47002 +2091
- Partials 6048 6652 +604
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tibrewalpratik17
force-pushed
the
refactor_upsert
branch
2 times, most recently
from
8e2c3fc
to
3f92d1b
Compare
tibrewalpratik17
force-pushed
the
refactor_upsert
branch
from
3f92d1b
to
3ded38a
Compare
Jackie-Jiang
approved these changes
Jun 27, 2024
.../src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java
Outdated
Show resolved
Hide resolved
suyashpatel98
pushed a commit
to suyashpatel98/pinot
that referenced
this pull request
Jul 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just like in #13396 , refactoring the upsert-manager class to have a consistent naming convention for removeSegment flow as well. Making
doRemoveSegmentflow an abstract method instead.Also we were passing
IndexSegment segment, MutableRoaringBitmap validDocIdsto the method but IMO passingrecordInfoIteratorinstead of validDocIds makes the method more generic. In #13347 we are planning to iterate through the entire segment and not just validDocID records so this change makes it easier to add unit-tests for that patch as well.